String tests in Java

NEVER test your input Strings this way:

public boolean equals(String arg) {
return arg.equals(MY_CONSTANT_STRING);
}

What happens if the input String “arg” is null ?! You’ll get a NullPointerException.
Rather than a cumbersome test of the input String nullity, implement your test this way (Java best practices) :

public boolean equals(String arg) {
return MY_CONSTANT_STRING.equals(arg);
}

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s